fix: Add error catching for renderTemplate of index.html #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jun 3, 2024
ghost
reviewed
Jun 3, 2024
ghost
suggested changes
Jun 3, 2024
There was a problem hiding this comment.
Hey @MatthewJohn I believe one of your commits is missing a signoff. Could you add one please?
Sorry, which commit? I didn't have a sign-off for the original (how would I go about that?) |
Ah okay - so it will sign it off as myself? |
|
@MatthewJohn yes, please sign off with the email address and name you use for your commits. Thank you! |
Signed-off-by: Matthew John <[email protected]>
Co-authored-by: Janos <[email protected]> Signed-off-by: Matthew John <[email protected]>
All done :) |
ghost
approved these changes
Jun 8, 2024
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.